Bump go-containerregistry version to use Kubernetes Secrets before cl… #3098
Conversation
…oud specific auth methods Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
go.mod
Outdated
| // TODO(hasheddan): we prefer to consume release versions of | ||
| // go-containerregistry. An incremental version is currently being used to | ||
| // consume the new k8schain implementation, which fixes an issue with | ||
| // reconcile timeouts when pulling packages in some environments. | ||
| github.com/google/go-containerregistry v0.8.1-0.20220302183023-329563766ce8 | ||
| github.com/google/go-containerregistry/pkg/authn/k8schain v0.0.0-20220302183023-329563766ce8 | ||
| github.com/google/go-containerregistry v0.8.1-0.20220414143355-892d7a808387 |
There was a problem hiding this comment.
@smileisak thanks so much for this update! It looks like the fix was included in google/go-containerregistry#1346, which was in the most recent release (https://github.com/google/go-containerregistry/releases/tag/v0.9.0). Could we pin to v0.9.0 and drop my TODO comment above?
There was a problem hiding this comment.
Yes, I though that we still have the issue of the reconcile timeouts when pulling packages in some environments. I'll update this MR to use the v0.9.0.
There was a problem hiding this comment.
@smileisak the update where we moved from a release version (e.g. v0.7.0) to an incremental version (e.g. v0.8.1-0.20220302183023-329563766ce8) was to fix the problem described. Because there wasn't a release version available we had to use the incremental version even though we prefer not to. Now that the previous fix, and the one you are including in this PR are in a release version v0.9.0 we can depend on it and drop my TODO as it is no longer applicable :)
…ion. Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
There was a problem hiding this comment.
LGTM! Thanks @smileisak -- I'll see about what backporting this looks like for a patch release given that it involves k8s dependency bumps 👍🏻
Bump go-containerregistry version to use Kubernetes Secrets before cloud specific auth methods
Signed-off-by: Ismail KABOUBI ikaboubi@gmail.com
Description of your changes
Fixes #3023
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I've run e2e tests locally using
make e2e. No need to add more unit tests / e2e tests since there is no changes in code.