[Backport release-1.7] Fix logger panic in dependency resolution and guard against future logger panic bugs #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes a panic in the logger when no version is supplied in the lock. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 6b1e057)
Updates all reconciler tests to use a test logger that mirrors Crossplane's logger in debug mode. All logs are discarded, but passing the logger will reveal any panics that result from any keys that are passed without values. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 83ef134)
3 tasks
hasheddan
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3103 to
release-1.7.