[Backport release-1.8] Fix string transform propagation #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Recently several new kinds of string transform were added, but we missed updating the (currently hand-curated) code that translates between a Composition and a CompositionRevision. This could lead to panics when the new kinds of transforms were used. Signed-off-by: Nic Cope <nicc@rk0n.org> (cherry picked from commit 4868fe0)
In cases where several string constants are all the same type that is a valid value for a particular API type we try to call the type 'FooType' and the various values 'FooTypeBar', 'FooTypeBaz', etc. Signed-off-by: Nic Cope <nicc@rk0n.org> (cherry picked from commit 8e8346b)
3 tasks
negz
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3158 to
release-1.8.