Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation guide for Azure #3166

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Conversation

riweston
Copy link
Contributor

@riweston riweston commented Jul 2, 2022

Description of your changes

Fixes #3131

The commands that are currently listed are deprecated.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Signed-off-by: Richard Weston <github@riweston.io>
This flag is deprecated

Signed-off-by: Richard Weston <github@riweston.io>
This is enough for the reources we can create in Azure

Signed-off-by: Richard Weston <github@riweston.io>
@riweston riweston marked this pull request as ready for review July 2, 2022 11:36
Signed-off-by: Richard Weston <github@riweston.io>
@riweston riweston changed the title style: Autoformatter Resolves #3131 Jul 2, 2022
@negz
Copy link
Member

negz commented Jul 6, 2022

@riweston Could you please update this PR to describe your changes per the template.

@patricekrakow
Copy link

I just run into the issue #3131, thanks to this PR I know how to fix it, but it would still be nice to have this PR merged :-)

@negz negz changed the title Resolves #3131 Update installation guide for Azure Aug 12, 2022
@negz
Copy link
Member

negz commented Aug 12, 2022

We haven't heard back from @riweston but it sounds like this update is useful, so I've edited the PR description to capture what it does. Thanks @riweston!

@negz negz merged commit c84b934 into crossplane:master Aug 12, 2022
@github-actions
Copy link

Successfully created backport PR #3227 for release-1.9.

@riweston
Copy link
Contributor Author

Whoops, sorry folks busy with work but glad this was useful - thanks @negz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Azure setup documentation is incorrect
3 participants