Bump crossplane-runtime and build submodule #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
approved these changes
Jul 14, 2022
|
Setting this to draft - looks like the below PR updated some reference types to add a policy field. We use those reference types in some places in core that won't honor the policy. I don't think we can use these types in core. |
|
Can we also include upbound/build#192 once its merged? |
Yes, will do. Edit: Done. |
Notably this doesn't make assumptions about BASH existing at /bin/bash, which it does not on my NixOS machine. Signed-off-by: Nic Cope <nicc@rk0n.org>
Notably this bumps the client-side rate-limits up fairly significantly (to ~5x per reconcile w/ ~10x burst). This should help us get packages with large payloads installed faster. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
force-pushed
the
bump
branch
2 times, most recently
from
1d2c729
to
ad7ae76
Compare
Previously we used *xpv1.Reference (from crossplane-runtime) in a few places in this codebase. This type was recently updated to add a 'policy' field that isn't applicable to core Crossplane's uses. Reference structs are simple enough that it seemed better to define our own than to depend on (and have to name!) a new kind of reference in crossplane-runtime. Signed-off-by: Nic Cope <nicc@rk0n.org>
This was referenced Aug 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I believe this will get us to sub 2 mins to install the "big three" jet providers (~1,800 CRDs).
Note that the
xpv1.Referencetype changed in the latest crossplane-runtime to include aPolicyfield. We don't use this field in core Crossplane so I've replaced our handful ofxpv1.Referenceuses with local structs. These reference structs are simple enough that it seemed better to define our own than to depend on (and have to name!) a new kind of reference in crossplane-runtime.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I've successfully deployed the "getting started with GCP" configuration from the https://crossplane.io documentation (with composition revisions enabled).