Upgrade to Go 1.18 #3200
Upgrade to Go 1.18 #3200
Conversation
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
| @@ -265,7 +265,7 @@ func (c *installProviderCmd) Run(k *kong.Context, logger logging.Logger) error { | |||
| } | |||
|
|
|||
| func warnIfNotFound(err error) error { | |||
| serr, ok := err.(*apierrors.StatusError) | |||
| serr, ok := err.(*apierrors.StatusError) //nolint:errorlint // we need to be able to extract the underlying typed error | |||
There was a problem hiding this comment.
Not sure why we need the nolint here. Could you elaborate?
There was a problem hiding this comment.
It was a lint error asking to use errors.As but that only returns a bool and we'd still have to cast it to *apierrors.StatusError later on
cmd/crank/install.go:268:14: type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
serr, ok := err.(*apierrors.StatusError)
| @@ -264,10 +264,10 @@ metadata: | |||
| name: vault-default | |||
| spec: | |||
| type: Vault | |||
| # defaultScope used for scoping secrets for cluster scoped resources. | |||
| # For example, secrets for MRs will land under | |||
| # defaultScope used for scoping secrets for cluster scoped resources. | |||
There was a problem hiding this comment.
Do we need these unrelated changes? Can we discard them?
| github.com/coreos/go-systemd v0.0.0-20180511133405-39ca1b05acc7/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4= | ||
| github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4= | ||
| github.com/coreos/go-systemd v0.0.0-20190620071333-e64a0ec8b42a/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4= | ||
| github.com/coreos/go-systemd/v22 v22.0.0/go.mod h1:xO0FLkIi5MaZafQlIrOotqXZ90ih+1atmu1JpKERPPk= |
There was a problem hiding this comment.
Do you know why so many removed in this file?
There was a problem hiding this comment.
Go 1.18 has module graph pruning:
If the main module is at go 1.17 or higher, the module graph used for minimal version selection includes only the immediate requirements for each module dependency that specifies go 1.17 or higher in its own go.mod file, unless that version of the module is also (transitively) required by some other dependency at go 1.16 or below. (The transitive dependencies of go 1.17 dependencies are pruned out of the module graph.)
There was a problem hiding this comment.
Got it, thanks for the explanation!
| @@ -1,6 +1,6 @@ | |||
| module github.com/crossplane/crossplane | |||
|
|
|||
| go 1.17 | |||
| go 1.18 | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
We can update crossplane-runtime version, too. It'd be great if you can run Crossplane with that change and see if it crashes or has anything unexpected in the logs 🙂
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma git@adi.run
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested