Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.8] Add secret delete permission to Core Crossplane #3209

Merged
merged 1 commit into from
Aug 13, 2022
Merged

[Backport release-1.8] Add secret delete permission to Core Crossplane #3209

merged 1 commit into from
Aug 13, 2022

Conversation

github-actions[bot]
Copy link

Description

Backport of #3206 to release-1.8.

@turkenh @github-actions
Add secret delete permission to Core Crossplane
932da67 
With ESS, we can no longer rely on K8s garbage collection to clean
up Composite secrets hence need explicit delete permissions.

Fixes #3195

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 1a3d468)
@github-actions github-actions bot requested review from muvaf and negz July 28, 2022 17:51
@github-actions github-actions bot mentioned this pull request Jul 28, 2022
Merged
3 tasks
@negz negz closed this Aug 12, 2022
@negz negz reopened this Aug 12, 2022
@negz negz merged commit 7db2452 into release-1.8 Aug 13, 2022
@negz negz deleted the backport-3206-to-release-1.8 branch August 13, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenh turkenh turkenh approved these changes

@muvaf muvaf Awaiting requested review from muvaf

@negz negz Awaiting requested review from negz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turkenh @negz