Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Upbound Registry login from CI and Promotion workflows #3215

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

hasheddan
Copy link
Member

Description of your changes

Drops the Upbound Registry login from the CI and Promotion workflows as
actual publishing of the Crossplane image to the Upbound Registry has
been removed, making this step extraneous.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Follow-up to #3065

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

This step is currently extraneous so it is not expected that its removal will impact the modified workflows.

Drops the Upbound Registry login from the CI and Promotion workflows as
actual publishing of the Crossplane image to the Upbound Registry has
been removed, making this step extraneous.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hasheddan hasheddan merged commit 76fab9f into crossplane:master Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Backport failed for release-1.7, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.7
git worktree add -d .worktree/backport-3215-to-release-1.7 origin/release-1.7
cd .worktree/backport-3215-to-release-1.7
git checkout -b backport-3215-to-release-1.7
ancref=$(git merge-base 64ae9457ca0d3191454c015e4c25136569639a29 319d7c0f7c240a4655b2c3901cd37783c819d1a6)
git cherry-pick -x $ancref..319d7c0f7c240a4655b2c3901cd37783c819d1a6

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Backport failed for release-1.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.8
git worktree add -d .worktree/backport-3215-to-release-1.8 origin/release-1.8
cd .worktree/backport-3215-to-release-1.8
git checkout -b backport-3215-to-release-1.8
ancref=$(git merge-base 64ae9457ca0d3191454c015e4c25136569639a29 319d7c0f7c240a4655b2c3901cd37783c819d1a6)
git cherry-pick -x $ancref..319d7c0f7c240a4655b2c3901cd37783c819d1a6

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Backport failed for release-1.9, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.9
git worktree add -d .worktree/backport-3215-to-release-1.9 origin/release-1.9
cd .worktree/backport-3215-to-release-1.9
git checkout -b backport-3215-to-release-1.9
ancref=$(git merge-base 64ae9457ca0d3191454c015e4c25136569639a29 319d7c0f7c240a4655b2c3901cd37783c819d1a6)
git cherry-pick -x $ancref..319d7c0f7c240a4655b2c3901cd37783c819d1a6

brunojdo pushed a commit to brunojdo/crossplane that referenced this pull request Aug 4, 2022
Remove Upbound Registry login from CI and Promotion workflows

Signed-off-by: Bruno Dias <bruno.dias@vtex.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants