Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on markdown link #3221

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Typo on markdown link #3221

merged 1 commit into from
Aug 4, 2022

Conversation

brunojdo
Copy link
Contributor

@brunojdo brunojdo commented Aug 4, 2022

Description of your changes

Just a nitpick found on the GOVERNANCE.md.

muvaf
muvaf approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muvaf
Copy link
Member

muvaf commented Aug 4, 2022

@brunojdo You'll need to sign your commit for us to be able to merge it, git commit -s --amend should work 🙂

@brunojdo
Typo on markdown link
aa3a24e 
Signed-off-by: Bruno Dias <bruno.dias@vtex.com.br>
@brunojdo
Copy link
Contributor Author

brunojdo commented Aug 4, 2022

@brunojdo You'll need to sign your commit for us to be able to merge it, git commit -s --amend should work 🙂

✅

@muvaf muvaf merged commit 366b543 into crossplane:master Aug 4, 2022
@brunojdo brunojdo deleted the patch-1 branch August 4, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muvaf muvaf muvaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunojdo @muvaf