Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MisterMX as a reviewer #3236

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Add MisterMX as a reviewer #3236

merged 1 commit into from
Aug 25, 2022

Conversation

negz
Copy link
Member

@negz negz commented Aug 16, 2022

Description of your changes

Fixes #3046

Max has already been working on some deep and valuable designs and improvements to Crossplane, and has expressed an interest in helping us review new contributions.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

N/A

@negz negz requested a review from a team as a code owner August 16, 2022 23:13
@negz negz requested review from bassam and jbw976 August 16, 2022 23:13
OWNERS.md Show resolved Hide resolved
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me — thanks @MisterMX !

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, too! @MisterMX is awesome!

@elohmrow
Copy link

🚀 ➕

@negz negz changed the title Add @MisterMX as a reviewer Add MisterMX as a reviewer Aug 17, 2022
@negz negz marked this pull request as draft August 17, 2022 22:46
@negz
Copy link
Member Author

negz commented Aug 17, 2022

@MisterMX you'll need to become an org member before we can proceed here. See https://github.com/crossplane/org/blob/main/processes/new-member.md for details on how to open an issue for that. Feel free to use myself and @hasheddan @muvaf or @jbw976 as sponsors.

@MisterMX
Copy link
Contributor

@negz thanks a lot for pushing this! I created a membership request: crossplane/org#45

@negz negz marked this pull request as ready for review August 22, 2022 17:02
@negz
Copy link
Member Author

negz commented Aug 22, 2022

This is pretty much ready to go - @MisterMX I just need you to accept your org invite and respond to my comment thread above.

Max has already been working on some deep and valuable designs and
improvements to Crossplane, and has expressed an interest in helping us
review new contributions.

Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz negz merged commit c76d45e into crossplane:master Aug 25, 2022
@negz negz deleted the ownership branch August 25, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository maintenance improvements
6 participants