Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in registry self-signed certs guide #3250

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

hasheddan
Copy link
Member

Description of your changes

Fixes a typo of Configure in the registry self-signed certs guide.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

n/a -- docs

Fixes a typo of Configure in the registry self-signed certs guide.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Copy link
Member Author

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbw976 hmm interesting 🤔 looks like your review doesn't actually allow for merge since the steering group isn't in the codeowners here -- I'm going to see if I can update.

@hasheddan
Copy link
Member Author

Actually, I think this may be working as intended. docs is falling through to the fallback, which is crossplane/reviewers or crossplane/maintainers. It probably makes sense for the steering committee to not be getting assigned to random reviews, and it looks like the crossplane/steering-committee assigns all three members. However, I do wonder if some steering committee members who also want to be more active in reviewing (i.e. maybe @jbw976) should be added to the crossplane/maintainers group as well?

@github-actions
Copy link

Successfully created backport PR #3254 for release-1.7.

@github-actions
Copy link

Successfully created backport PR #3255 for release-1.8.

@github-actions
Copy link

Successfully created backport PR #3256 for release-1.9.

@jbw976
Copy link
Member

jbw976 commented Aug 22, 2022

I do wonder if some steering committee members who also want to be more active in reviewing (i.e. maybe @jbw976) should be added to the crossplane/maintainers group as well?

I'll try to earn it back over the next few months as I get more involved with community/reviews 💪 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants