Use rooted paths in CODEOWNERS #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses rooted paths in CODEOWNERS such that the paths are exact. Not specifying the root means that an arbitrarily nested directory that matched part of its path to one of the paths in the CODEOWNERS file would receive the same review requests. This makes the exact paths explicit. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Fixes wording in CODEOWNERS regarding how the review process should typically work. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Is this still the case? |
Hrm weird, didn't see it in GitHub mobile but I see it now. |
negz
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Uses rooted paths in CODEOWNERS such that the paths are exact.
Not specifying the root means that an arbitrarily nested directory that
matched part of its path to one of the paths in the CODEOWNERS file
would receive the same review requests. This makes the exact paths explicit.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
This is based on my interpretation of https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.
Fixes wording in CODEOWNERS regarding how the review process should
typically work.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
n/a -- I don't think this is going to have functional changes initially, but it protects us from accidentally specifying CODEOWNERs implicitly in the future.