Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a handful of Upbound reviewers #3257

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add a handful of Upbound reviewers #3257

merged 1 commit into from
Aug 23, 2022

Conversation

negz
Copy link
Member

@negz negz commented Aug 22, 2022

Description of your changes

I'd like to add the following reviewers to help keep things moving along:

  • Yury is a maintainer of provider-terraform, and has plenty of Kubernetes development experience as the TL of https://www.k8gb.io.
  • Daren and Nathan both work on https://marketplace.upbound.io, which is a marketplace for Crossplane packages. Dan Mangum suggested them as folks with great potentials to become package manager experts.

We're conscious of not having Upbound employees dominate the reviewers list long term; we're planning on putting forward no more than six reviewers for the time being with a goal of having at least that many non-Upbound reviewers.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

N/A

I'd like to add the following reviewers to help keep things moving
along:

* Yury is a maintainer of provider-terraform, and has plenty of
  Kubernetes development experience as the TL of https://www.k8gb.io.
* Daren and Nathan both work on https://marketplace.upbound.io, which is
  a marketplace for Crossplane packages. Dan Mangum suggested them as
  folks with great potentials to become package manager experts.

We're conscious of not having Upbound employees dominate the reviewers
list long term; we're planning on putting forward no more than six
reviewers for the time being with a goal of having at least that many
non-Upbound reviewers.

Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz negz requested a review from a team as a code owner August 22, 2022 17:25
@negz negz requested review from bassam and jbw976 August 22, 2022 17:25
@negz negz merged commit 435679e into crossplane:master Aug 23, 2022
@negz negz deleted the reviewers branch August 23, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants