[Backport release-1.8] Use package revision name to identify self when adding or removing from Lock #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Passing NodeFns proved to not be a very ergonomic API to work with and most places where FindIndex was used could be replaced by either working with the Nodes directly or calling NodeExists. The index of a Node should not be the responsibility of the DAG, which provides an interface into a graph. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit c5f0761)
Updates the package revision dependency manager to use the package revision name to identify self in the Lock. This prevents the case of one package revision attempting to remove itself from the Lock while another is adding with the same source. Source is still used as an identifier in the DAG as it dictates whether we determine a dependency is present or not. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit cdcf68f)
Updates the package revision dependency manager unit tests to accommodate using package revision name to identify self in the Lock. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 6ef237a)
Updates DAG unit tests to remove unused variable. Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 2f90106)
3 tasks
hasheddan
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3304 to
release-1.8.