Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note recommending usage of SPDX License Identifiers #3344

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

hasheddan
Copy link
Member

Description of your changes

Adds a note to the xpkg specification recommending that an SPDX License Identifier be used for the license annotation. This is not strictly required because it is not expected that tooling will reject a package that uses a non-valid SPDX License Identifier.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Verified link renders correctly.

Adds a note to the xpkg specification recommending that an SPDX License
Identifier be used for the license annotation. This is not strictly
required because it is not expected that tooling will reject a package
that uses a non-valid SPDX License Identifier.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hasheddan!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Successfully created backport PR #3351 for release-1.7.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Successfully created backport PR #3352 for release-1.8.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Successfully created backport PR #3353 for release-1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants