Docs: fix CombineFromComposite patch example
#3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
reviewed
Oct 4, 2022
docs/reference/composition.md
Outdated
| @@ -438,14 +438,14 @@ composed resource field. | |||
|
|
|||
| ```yaml | |||
| # Patch from the XR's spec.parameters.location field and the | |||
| # metadata.annotations[crossplane.io/claim-name] annotation to the composed | |||
| # metadata.labels[crossplane.io/claim-name] annotation to the composed | |||
There was a problem hiding this comment.
Suggested change
| # metadata.labels[crossplane.io/claim-name] annotation to the composed | |
| # metadata.labels[crossplane.io/claim-name] label to the composed |
There was a problem hiding this comment.
@hasheddan amended, thanks a lot for the catch!
`crossplane.io/claim-name` is a label, not an annotation Signed-off-by: Yury Tsarev <yury@upbound.io>
ytsarev
force-pushed
the
fix-doc-claim-name
branch
from
8526c62
to
35a8649
Compare
hasheddan
approved these changes
Oct 4, 2022
|
Successfully created backport PR #3357 for |
|
Successfully created backport PR #3358 for |
|
Successfully created backport PR #3359 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
crossplane.io/claim-nameis a label, not an annotationSigned-off-by: Yury Tsarev yury@upbound.io
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested