Validate Composition and configure XR before fetching environment #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way if our Composition is invalid or we fail to configure the XR (often using the Composition) we'll fail early without hitting the environment select/fetch logic unnecessarily. Signed-off-by: Nic Cope <nicc@rk0n.org>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This way if our Composition is invalid or we fail to configure the XR (often using the Composition) we'll fail early without hitting the environment select/fetch logic unnecessarily.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I haven't tested this, so I'm opening it as a draft to get feedback from folks who know the implementation better before I do. @MisterMX @ytsarev do you think this makes sense?