Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Renault in ADOPTERS list #3710

Merged
merged 1 commit into from
Feb 3, 2023
Merged

adding Renault in ADOPTERS list #3710

merged 1 commit into from
Feb 3, 2023

Conversation

smileisak
Copy link
Contributor

Description of your changes

Adding Renault to ADOPTERS file.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Only documentation added.

@smileisak smileisak requested review from a team as code owners February 2, 2023 19:26
@smileisak smileisak requested review from turkenh and nullable-eth and removed request for a team February 2, 2023 19:26
@smileisak smileisak changed the title adding Renault as ADOPTERS adding Renault in ADOPTERS list Feb 2, 2023
@jeanduplessis jeanduplessis requested review from jbw976 and removed request for turkenh and nullable-eth February 2, 2023 20:30
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for making this addition to the adopters list @smileisak!! 🎉

@jbw976
Copy link
Member

jbw976 commented Feb 2, 2023

We've got a few of these additions to the adopters list today, so we'll be taking them in the order that they were opened.

Unfortunately, that means a small merge conflict to handle - #3709 is next in line, so I would maybe wait till after that is merged and then handle the conflict after that.

Looks like this can be done from Github also by a maintainer, so let me know if you want me to try that experience out too - never used it before ;)

@jbw976
Copy link
Member

jbw976 commented Feb 3, 2023

now that #3709 is in, it's your turn to handle a merge conflict and add your entry to the end of the list @smileisak!

Please let me know if you need any help with resolving the merge conflict, I am happy to take care of that myself and prevent any headaches for you 😇

Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
@smileisak
Copy link
Contributor Author

@jbw976 it should be ok now.

@negz negz merged commit 1812787 into crossplane:master Feb 3, 2023
@jbw976 jbw976 mentioned this pull request Feb 3, 2023
3 tasks
@smileisak smileisak mentioned this pull request Jan 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants