Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag: improve fuzzer #4200

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Jun 19, 2023

Description of your changes

Adds more calls to the DAG fuzzer to improve coverage.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

go test -fuzz=FuzzDag

Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz AdamKorcz requested review from a team and hasheddan as code owners June 19, 2023 12:33
@AdamKorcz AdamKorcz requested a review from jbw976 June 19, 2023 12:33
@phisco
Copy link
Contributor

phisco commented Jun 20, 2023

@AdamKorcz you can run GO_LINT_ARGS=" --fix " make reviewable to fix the linter issues reported

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco phisco self-requested a review June 23, 2023 11:09
@phisco
Copy link
Contributor

phisco commented Jun 23, 2023

@AdamKorcz looks like the fuzzing is actually failing, I think it's related to the test code and not an finding from the fuzzing, could you have a look?

@AdamKorcz
Copy link
Contributor Author

@AdamKorcz you can run GO_LINT_ARGS=" --fix " make reviewable to fix the linter issues reported

Does this still exist in the Makefile?

Signed-off-by: AdamKorcz <adam@adalogics.com>
@phisco
Copy link
Contributor

phisco commented Jun 29, 2023

@AdamKorcz yes, maybe you'll have to init the build submodule first

@phisco phisco self-requested a review July 20, 2023 07:01
internal/dag/dag.go Outdated Show resolved Hide resolved
Co-authored-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
@turkenh turkenh merged commit ad0ff7d into crossplane:master Aug 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants