Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add SIG info in readme #4287

Merged
merged 2 commits into from
Jul 22, 2023
Merged

doc: Add SIG info in readme #4287

merged 2 commits into from
Jul 22, 2023

Conversation

csantanapr
Copy link
Contributor

@csantanapr csantanapr commented Jun 30, 2023

Description of your changes

Add SIG list in readme

Fixes #4283

I have:

  • Read and followed Crossplane's contribution process.
  • Added or updated unit and E2E tests for my change.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

@csantanapr csantanapr requested a review from a team as a code owner June 30, 2023 19:58
@csantanapr csantanapr changed the title Add SIG info in readme doc: Add SIG info in readme Jun 30, 2023
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csantanapr! This just needs to be wrapped and then I think it looks good.

In future it would be nice to find a way to list what SIGs exist that doesn't require README updates. I'd like to be able to spin them up and down a little dynamically perhaps. This works for now though.

README.md Outdated Show resolved Hide resolved
@csantanapr
Copy link
Contributor Author

@negz

In future it would be nice to find a way to list what SIGs exist that doesn't require README updates. I'd like to be able to spin them up and down a little dynamically perhaps.

Open to suggestions that would be viable for the crossplane community, they can be part of the docs that get read from a file

Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
@phisco phisco merged commit d871cd6 into crossplane:master Jul 22, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README with SIG list
3 participants