composite: fix nil-dereference #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AdamKorcz <adam@adalogics.com>
phisco
approved these changes
Jul 25, 2023
lsviben
approved these changes
Jul 25, 2023
|
I see that the e2e-tests are failing. I dont think its connected with this change, maybe we have a flaky test? https://github.com/crossplane/crossplane/actions/runs/5656509598/job/15323691974?pr=4380 Ill rerun the e2e test ci |
|
yes, that test is flaky @lsviben, we'll check that later on |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes a nil-dereference found by OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58445.
If
inputis nil, then thereflect.TypeOf(input).String()will throw a nil-dereference.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.