ci: add cleanup disk step before publish #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
|
renovate will take care of pinning the hash in a dedicated PR once this one is merged. |
|
Related PRs for v1.11 and v1.12: |
jbw976
approved these changes
Jul 27, 2023
Comment on lines
+311
to
+313
| android: true | ||
| dotnet: true | ||
| haskell: true |
There was a problem hiding this comment.
There was a problem hiding this comment.
"True" means "delete them" so it's a good thing these don't sound familiar to you, it means we are not deleting anything useful 😂
|
Successfully created backport PR for |
|
Would this also clean up the go package caches?
|
MisterMX
reviewed
Oct 10, 2023
| @@ -305,6 +305,16 @@ jobs: | |||
| if: needs.detect-noop.outputs.noop != 'true' | |||
|
|
|||
| steps: | |||
| - name: Cleanup Disk | |||
| uses: jlumbroso/free-disk-space@main | |||
There was a problem hiding this comment.
@phisco just a hint that, as discussed in crossplane-contrib/provider-aws#1888 (comment), this always defaults to what is in the main and might better be pinned.
There was a problem hiding this comment.
Oh, I was expecting renovate to propose that change after merge 🤔 good catch!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Recently we've had many cases of errors due to "no space left on device" during the publish step in the CI job, this is a pretty common issue with multi arch images' builds, so we decided to add a preliminary cleanup step at the beginning of the publish step to cleanup a few unneeded files (saving ~30GB).
With @ezgidemirel we had to merge it first on release-1.11 and release-1.12 branches because it was blocking the release of 1.13. But it's definitely worth adding it to master and backport it to 1.13 too, although we were lucky and didn't hit that on the latter.
I have:
Added or updated unit and E2E tests for my change.Runmake reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.