inject noop logger by default to ctrl-runtime to avoid warnings #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsviben <sviben.lovro@gmail.com>
|
Given that we couldn't reproduce it, no need to get it in alongside #4402, still I think it's worth getting it in main and release-1.13 👍 |
|
I could reproduce this with v1.13.0 by installing provider-nop, and seeing stack trace both in core and rbac manager. I think it happens after the first log attempt which is triggered by a package installation. |
phisco
approved these changes
Jul 28, 2023
turkenh
approved these changes
Jul 28, 2023
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
controller-runtime v0.15.0 introduced a warning if the logger is not set for it through
crtl.SetLogger.Except in debug mode, we dont set a logger for it as its too verbose. But as now we get a stack trace warning, adding a noop logger explicity to avoid it.
Fixes #
I have:
Added or updated unit and E2E tests for my change.make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.