Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move muvaf from maintainers to emeritus #4518

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Move muvaf from maintainers to emeritus #4518

merged 1 commit into from
Aug 25, 2023

Conversation

muvaf
Copy link
Member

@muvaf muvaf commented Aug 24, 2023 

It has been an honor to serve as maintainer in Crossplane
project for the last 4 years. My focus has slightly
shifted from infrastructure and I'd like to give room
for the next generation of folks stepping up. I have
full trust that they will be the best stewards of the
project going forward - it's Crossplane, it always
reconciles towards the best desired state.

"And now, I think I am quite ready to go on another
journey. Are you coming?" - Bilbo, the Oldest Hobbit

Signed-off-by: Muvaffak Onus <me@muvaf.com>

@muvaf
Move muvaf from maintainers to emeritus
e6f33c1 
It has been an honor to serve as maintainer in Crossplane
project for the last 4 years. My focus has slightly
shifted from infrastructure and I'd like to give room
for the next generation of folks stepping up. I have
full trust that they will be the best stewards of the
project going forward - it's Crossplane, it always
reconciles towards the best desired state.

"And now, I think I am quite ready to go on another
journey. Are you coming?" - Bilbo, the Oldest Hobbit

Signed-off-by: Muvaffak Onus <me@muvaf.com>
@muvaf muvaf requested review from a team as code owners August 24, 2023 17:34
@muvaf muvaf requested review from negz, bassam and jbw976 August 24, 2023 17:34
bassam
bassam approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@bassam bassam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Muvaf for all your contributions to the project!

negz
negz approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muvaf! You've been instrumental in helping Crossplane find its footing.

CODEOWNERS
Comment on lines +46 to +48
/apis/apiextensions/ @crossplane/crossplane-reviewers @turkenh
/internal/xcrd/ @crossplane/crossplane-reviewers @turkenh
/internal/controller/apiextensions/ @crossplane/crossplane-reviewers @turkenh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to take this too unless there's another volunteer (@phisco?), given that @turkenh is already owner for the package manager.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Fine with me!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as-is and we can update later.

jbw976
jbw976 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jbw976 jbw976 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so very much @muvaf for all of your efforts to get the project to where it is today, no question in my mind that your contributions were enormous! 💪

edit: lol at the branch name 😂

@negz negz merged commit fd47949 into crossplane:master Aug 25, 2023
14 of 15 checks passed
negz added a commit to negz/crossplane that referenced this pull request Sep 13, 2023
@negz
Use server-side apply when in mode: Pipeline
3a0c682 
This commit updates the FunctionComposer to use SSA to create and update
composed resources, and to update the XR. I don't believe adopting SSA
in this context warrants its own feature flag, since Functions are a new
feature in themselves, and we only use SSA to power Functions.

It also limits Composition Functions to effecting only an XR's status.
The Composition Function pipeline cannot effect an XR's metadata or
spec. This is in service of crossplane#4518, which proposes that:

* metadata and spec flow claim -> XR -> composed resources
* status flow composed resources -> XR -> claim

A Function that returns desired XR metadata or spec will be ignored.

Signed-off-by: Nic Cope <nicc@rk0n.org>
negz added a commit to negz/crossplane that referenced this pull request Sep 13, 2023
@negz
Use server-side apply when in mode: Pipeline
55ddc43 
This commit updates the FunctionComposer to use SSA to create and update
composed resources, and to update the XR. I don't believe adopting SSA
in this context warrants its own feature flag, since Functions are a new
feature in themselves, and we only use SSA to power Functions.

It also limits Composition Functions to effecting only an XR's status.
The Composition Function pipeline cannot effect an XR's metadata or
spec. This is in service of crossplane#4518, which proposes that:

* metadata and spec flow claim -> XR -> composed resources
* status flow composed resources -> XR -> claim

A Function that returns desired XR metadata or spec will be ignored.

Signed-off-by: Nic Cope <nicc@rk0n.org>
negz added a commit to negz/crossplane that referenced this pull request Sep 13, 2023
@negz
Use server-side apply when in mode: Pipeline
683f0c5 
This commit updates the FunctionComposer to use SSA to create and update
composed resources, and to update the XR. I don't believe adopting SSA
in this context warrants its own feature flag, since Functions are a new
feature in themselves, and we only use SSA to power Functions.

It also limits Composition Functions to effecting only an XR's status.
The Composition Function pipeline cannot effect an XR's metadata or
spec. This is in service of crossplane#4518, which proposes that:

* metadata and spec flow claim -> XR -> composed resources
* status flow composed resources -> XR -> claim

A Function that returns desired XR metadata or spec will be ignored.

Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz approved these changes

@phisco phisco phisco left review comments

@bassam bassam bassam approved these changes

@jbw976 jbw976 jbw976 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@muvaf @negz @bassam @jbw976 @phisco