-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiextension/definition: tame "Applied composite resource CRD" event #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
changed the title
apiextension/definition: tame "Applied composite resource CRD" event
WIP: apiextension/definition: tame "Applied composite resource CRD" event
Sep 5, 2023
Bumped crossplane-runtime. So it should compile now. |
sttts
changed the title
WIP: apiextension/definition: tame "Applied composite resource CRD" event
apiextension/definition: tame "Applied composite resource CRD" event
Sep 6, 2023
5 tasks
turkenh
reviewed
Sep 6, 2023
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
turkenh
approved these changes
Sep 6, 2023
negz
added a commit
to negz/crossplane
that referenced
this pull request
Feb 1, 2024
crossplane#4575 This follows up the above PR: * Applies the changes to the controller that manages claim controllers * Removes some events about stopping controllers Signed-off-by: Nic Cope <nicc@rk0n.org>
6 tasks
negz
added a commit
to negz/crossplane
that referenced
this pull request
Feb 1, 2024
crossplane#4575 This follows up the above PR: * Applies the changes to the controller that manages claim controllers * Removes some events about stopping controllers Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
added a commit
to negz/crossplane
that referenced
this pull request
Feb 1, 2024
crossplane#4575 This follows up the above PR: * Applies the changes to the controller that manages claim controllers * Removes some events about stopping controllers Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
added a commit
to negz/crossplane
that referenced
this pull request
Feb 1, 2024
crossplane#4575 This follows up the above PR: * Applies the changes to the controller that manages claim controllers * Removes some events about stopping controllers Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Applied composite resource CustomResourceDefinition
if nothing changed.Applied composite resource CustomResourceDefinition: <name>
.Rendered composite resource CustomResourceDefinition
Referenceable version changed; stopped composite resource controller
(Re)started composite resource controller
.Needs crossplane/crossplane-runtime#534.
I have:
Added or updated unit and E2E tests for my change.make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.