Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextension/definition: tame "Applied composite resource CRD" event #4575

Merged
merged 7 commits into from
Sep 6, 2023

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 5, 2023

Description of your changes

  1. suppress Applied composite resource CustomResourceDefinition if nothing changed.
  2. add what matters: which CRD was applied: Applied composite resource CustomResourceDefinition: <name>.
  3. remove events in the XRD controller that are debug output, shouldn't be user facing.
    • Rendered composite resource CustomResourceDefinition
    • Referenceable version changed; stopped composite resource controller
    • (Re)started composite resource controller.
  4. included controller/rbac: tame "Applied RBAC ClusterRole" event #4572 about RBAC events.

Needs crossplane/crossplane-runtime#534.

I have:

  • Read and followed Crossplane's contribution process.
  • Added or updated unit and E2E tests for my change.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, if necessary.
  • Opened a PR updating the docs, if necessary.

@sttts sttts requested review from turkenh and a team as code owners September 5, 2023 20:39
@sttts sttts requested a review from jbw976 September 5, 2023 20:39
@sttts sttts changed the title apiextension/definition: tame "Applied composite resource CRD" event WIP: apiextension/definition: tame "Applied composite resource CRD" event Sep 5, 2023
@negz negz marked this pull request as draft September 5, 2023 23:52
@sttts
Copy link
Contributor Author

sttts commented Sep 6, 2023

Bumped crossplane-runtime. So it should compile now.

@sttts sttts changed the title WIP: apiextension/definition: tame "Applied composite resource CRD" event apiextension/definition: tame "Applied composite resource CRD" event Sep 6, 2023
@sttts sttts marked this pull request as ready for review September 6, 2023 08:20
@sttts sttts requested review from negz and a team as code owners September 6, 2023 08:20
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
@turkenh turkenh merged commit 676a86d into crossplane:master Sep 6, 2023
15 checks passed
negz added a commit to negz/crossplane that referenced this pull request Feb 1, 2024
crossplane#4575

This follows up the above PR:

* Applies the changes to the controller that manages claim controllers
* Removes some events about stopping controllers

Signed-off-by: Nic Cope <nicc@rk0n.org>
negz added a commit to negz/crossplane that referenced this pull request Feb 1, 2024
crossplane#4575

This follows up the above PR:

* Applies the changes to the controller that manages claim controllers
* Removes some events about stopping controllers

Signed-off-by: Nic Cope <nicc@rk0n.org>
negz added a commit to negz/crossplane that referenced this pull request Feb 1, 2024
crossplane#4575

This follows up the above PR:

* Applies the changes to the controller that manages claim controllers
* Removes some events about stopping controllers

Signed-off-by: Nic Cope <nicc@rk0n.org>
negz added a commit to negz/crossplane that referenced this pull request Feb 1, 2024
crossplane#4575

This follows up the above PR:

* Applies the changes to the controller that manages claim controllers
* Removes some events about stopping controllers

Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants