Hardwire the XR Reconciler to use *composite.Unstructured
#4614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we mostly accepted the resource.Composite interface, but in practice neither Composer that the Reconciler can use would work with any underlying type apart from *composite.Unstructured. Having the Composer interface require that type makes this explicit. The PTComposer needs an unstructured type in order to fieldpath.Pave and patch it. The FunctionComposer needs and unstructured type in order to use server-side apply. Signed-off-by: Nic Cope <nicc@rk0n.org>
turkenh
approved these changes
Sep 14, 2023
phisco
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Previously we mostly accepted the resource.Composite interface, but in practice neither Composer that the Reconciler can use would work with any underlying type apart from *composite.Unstructured. Having the Composer interface require that type makes this explicit.
The
PTComposerneeds an unstructured type in order tofieldpath.Paveand patch it. TheFunctionComposerneeds and unstructured type in order to use server-side apply.I have:
Added or updated unit and E2E tests for my change.make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.