Add Functions to the xpkg spec #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
requested review from
phisco and
ezgidemirel
and removed request for
bobh66 and
lsviben
phisco
approved these changes
Sep 18, 2023
lsviben
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This one is kinda "what it says on the tin". 馃槃
One note that didn't seem like a good fit for the spec (and I'm not sure where to record) is that as a beta feature
Functiononly has av1beta1API version. That is, for now, the meta type will always be:This is unlike Providers and Configurations, which support
v1and an identicalv1alpha1type.I have:
Added or updated unit and E2E tests for my change.Runmake reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.