functions/proto: clarify that desired state must be SSA compatible #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phisco
reviewed
Sep 26, 2023
phisco
reviewed
Sep 26, 2023
Comment on lines
49
to
50
| // likely not what you want to do. Leaving out fields that had been returned | ||
| // as desired before are going to be deleted from the objects in the cluster. |
There was a problem hiding this comment.
Obviously here too 😅
Suggested change
| // likely not what you want to do. Leaving out fields that had been returned | |
| // as desired before are going to be deleted from the objects in the cluster. | |
| // likely not what you want to do. Leaving out fields that had been returned | |
| // as desired before will result in them being deleted from the objects in the | |
| // cluster. |
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
sttts
force-pushed
the
sttts-function-clarification
branch
from
1fd1d93
to
2fbf157
Compare
phisco
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Clarify semantics of the desired state in function requests and responses, namely that it must be a partial object with exactly those fields (only those and a complete set) that the function pipeline is interested in.
I have:
Added or updated unit and E2E tests for my change.make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.