Deploy to kind cluster with debugging on #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While development/testing locally, it is very useful to have debug logs turned on. Signed-off-by: Predrag Knezevic <predrag.knezevic@upbound.io>
pedjak
force-pushed
the
debug-kind-deployment
branch
from
9ff0846
to
318c21f
Compare
phisco
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
I agree, I always run it as HELM3_FLAGS="--set args={--debug} " ./cluster/local/kind.sh helm-upgrade. The main issue of setting this as default is that helm is not going to merge args if you add custom ones, so you'll have to remember to add --debug it back again later, but I agree it's a better default.
bobh66
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While development/testing locally, it is very useful to have
debug logs turned on.
I have:
make reviewableto ensure this PR is ready for review.