fix(message): fix event message to print composition revision #4714
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
approved these changes
Oct 2, 2023
phisco
reviewed
Oct 2, 2023
| @@ -538,7 +538,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (reco | |||
| return reconcile.Result{Requeue: true}, errors.Wrap(r.client.Status().Update(ctx, xr), errUpdateStatus) | |||
| } | |||
| if rev := xr.GetCompositionRevisionReference(); rev != nil && (origRev == nil || *rev != *origRev) { | |||
| r.record.Event(xr, event.Normal(reasonResolve, "Selected composition revision: %s", rev.Name)) | |||
| r.record.Event(xr, event.Normal(reasonResolve, fmt.Sprintf("Selected composition revision: %s", rev.Name))) | |||
There was a problem hiding this comment.
Normal takes key/value pairs from the 3rd argument on, so the other option here is to make it
Suggested change
| r.record.Event(xr, event.Normal(reasonResolve, fmt.Sprintf("Selected composition revision: %s", rev.Name))) | |
| r.record.Event(xr, event.Normal(reasonResolve, "Selected composition revision", "name", rev.Name))) |
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
haarchri
force-pushed
the
fix/message-#4708
branch
from
0fcaa29
to
aaaeafd
Compare
phisco
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
before this PR:
Selected composition revision: %!s(MISSING)after this PR:
Selected composition revision: xclusters.aws.caas.upbound.io-5ebaa5eFixes #4708
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, if necessary.