fix(roles): System ProviderRevision named clusterRoles should have labels #4716
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #4160
This adds the provider revision name as a label with the key that was initially discussed in the issue
rbac.crossplane.io/system
This
pr.GetName()
is used throughout thisroles.go
and prior to its use here so it shouldnt be an issue to use it to label these cluster roles. The tests also show that this changeI have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, if necessary.