Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpkg push #4721

Merged
merged 1 commit into from
Oct 9, 2023
Merged

xpkg push #4721

merged 1 commit into from
Oct 9, 2023

Conversation

lsviben
Copy link
Contributor

@lsviben lsviben commented Oct 3, 2023

Description of your changes

Moved a simplified version of crossplane push provider/configuration to crossplane xpkg push.

Not moving the whole up xpkg push, at least for now.
The new version also supports functions, while the old one should be deprecated in time.

Fixes #4669

I have:

How has this been tested

Ran kubectl crossplane push provider <tag> and the new kubectl crossplane xpkg push <tag> and got the same result.

Signed-off-by: lsviben <sviben.lovro@gmail.com>
@lsviben lsviben requested review from negz and a team as code owners October 3, 2023 16:54
@lsviben lsviben requested a review from pedjak October 3, 2023 16:54
@phisco
Copy link
Contributor

phisco commented Oct 6, 2023

Trying to diff this w.r.t. up xpkg push as defined here:

  • up supports all the upbound.Flags, which allow to specify Upbound specific settings to access the marketplace, we won't
  • up creates a repository in the marketplace if it doesn't exist (--create true), we won't
  • up supported passing multiple packages, we won't.
  • up inferred desired annotations and applied them for flattened packages as introduced here, we won't

Diffing with crank push <configuration|provider> as defined here the only difference is that we are removing the resource specific subcommand.

@phisco
Copy link
Contributor

phisco commented Oct 6, 2023

Do we want to deprecate crank build|push?

@lsviben
Copy link
Contributor Author

lsviben commented Oct 9, 2023

Do we want to deprecate crank build|push?

Makes sense. We can do in in a separate pr?

@phisco phisco merged commit 2ae0acc into crossplane:master Oct 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build/compile and push Functions to a registry
3 participants