tests(e2e): related objects working also for claims #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm actually not sure I got the graph right, should we get the Claim's |
|
Got my answer: https://github.com/crossplane/crossplane/actions/runs/6430195964/job/17460739141?pr=4740#step:12:492, it's the other way around, need to get |
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
phisco
force-pushed
the
e2e/claims-related-objects
branch
from
20e8913
to
4499f8e
Compare
|
As you can see by the e2e failures it's now working fine 😅 |
sttts
approved these changes
Oct 6, 2023
turkenh
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow up to #4594 taking into account claims, which not being set as owners of the XR resulted in empty related objects, as you can see here.
I have:
Added or updated unit and E2E tests for my change.make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.