ci(configurations): remove unused getting started configurations #4766
Conversation
phisco
force-pushed
the
fix/configure-job
branch
from
68e2219
to
f8cfaa9
Compare
|
waiting to see if it actually works on my fork |
phisco
force-pushed
the
fix/configure-job
branch
2 times, most recently
from
c86716f
to
5e1827e
Compare
|
Pushed to a branch on this repo and triggered manually to test it properly. Working fine: https://github.com/crossplane/crossplane/actions/runs/6469904088
|
|
switched to
|
.github/workflows/configurations.yml
Outdated
| - { name: "getting-started-with-aws", path: "cluster/packages/aws/getting-started-aws.xpkg" } | ||
| - { name: "getting-started-with-aws-with-vpc", path: "cluster/packages/aws-with-vpc/getting-started-with-aws-with-vpc.xpkg" } | ||
| - { name: "getting-started-with-gcp", path: "cluster/packages/gcp/getting-started-with-gcp.xpkg" } | ||
| - { name: "getting-started-with-azure", path: "cluster/packages/azure/getting-started-with-gcp.xpkg" } |
There was a problem hiding this comment.
CC @plumbis to confirm, but I don't think these are actually used anymore. They were part of our documentation before the new docs.crossplane.io site. If they're unused we could probably delete them.
There was a problem hiding this comment.
this would be even better, let me know if we can remove them @plumbis, if that's the case, should we drop them also from the marketplace?
There was a problem hiding this comment.
None of these are in the docs. There are references to the older snippets docs directory but that stuff is all contained inside the docs.
Docs has no dependencies on this.
There was a problem hiding this comment.
So I'm going to drop this action and remove the steps from the release procedure 👍
There was a problem hiding this comment.
Removed in a separate commit, so if we ever want to switch back the new job will still be in the history.
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
phisco
force-pushed
the
fix/configure-job
branch
from
79e34a9
to
285c7d1
Compare
phisco
changed the title
Description of your changes
Fixes broken configurations builds due to the switch fromkubectl-crossplanetocrossplaneRemoved "getting started" configurations and actions building and pushing them.
I have:
Added or updated unit and E2E tests for my change.make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.