k8s API sets the default value of claim's spec.compositeDeletePolicy field
#4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobh66
reviewed
Oct 10, 2023
negz
reviewed
Oct 11, 2023
phisco
reviewed
Oct 12, 2023
pedjak
force-pushed
the
claim-default-deletion-policy
branch
from
2f2c29f
to
ac3f3cc
Compare
5 tasks
negz
approved these changes
Oct 13, 2023
…` field * claim CRD contains now the default value for `.spec.compositeDeletePolicy` field copied from XRD `spec.defaultCompositeDeletePolicy`. If not specified at claim, it will be set by k8s API * claim controller does not set the value for `spec.compositeDeletePolicy`, leading to one less claim update, and hence one less no-op reconcile loop * added unit and e2e tests * removed `APIDefaultSelector` as unneeded Signed-off-by: Predrag Knezevic <predrag.knezevic@upbound.io>
pedjak
force-pushed
the
claim-default-deletion-policy
branch
from
ac3f3cc
to
ca10547
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
.spec.compositeDeletePolicyfieldcopied from XRD
spec.defaultCompositeDeletePolicy. If not specified at claim,it will be set by k8s API
spec.compositeDeletePolicy,leading to one less claim update, and hence one less no-op reconcile loop
APIDefaultSelectoras unneededFixes #4691
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, if necessary.