feat(crank): drop duplicated build/push commands #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
negz
approved these changes
Oct 16, 2023
Comment on lines
-72
to
-75
| // Run runs the install cmd. | ||
| func (c *installCmd) Run(_ *buildChild) error { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Was this intentional? I see you said you were leaving install for now - I'm guessing this is a no-op change?
There was a problem hiding this comment.
Yes, the actual commands are implemented in the subcommands' Run. Not really sure why these were there.
Comment on lines
-31
to
-34
| // Run runs the update cmd. | ||
| func (c *updateCmd) Run(_ *buildChild) error { | ||
| return nil | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Address the uncontroversial part of #4783, dropping
buildandpushsubcommands in favor of the implementations atxpkg buildandxpkg push. Left moving install and update to a later stage when a decision on #4783 has been taken, just to avoid moving them around twice.I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.