e2e: wait for all nop resource deleted before deleting prerequisites #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
force-pushed
the
wait-for-it
branch
4 times, most recently
from
dd1c95f
to
68914d0
Compare
pedjak
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
given that we repeat the following block so many times:
WithTeardown("DeletePrerequisites", funcs.AllOf(
funcs.ListedResourcesDeletedWithin(2*time.Minute, nopList),
funcs.DeleteResources(manifests, "setup/*.yaml"),
funcs.ResourcesDeletedWithin(3*time.Minute, manifests, "setup/*.yaml"),
)).perhaps would be nice to improve readability by wrapping them into funcs.DeletePrerequisites function and get something like:
WithTeardown("DeletePrerequisites", funcs.DeletePrerequisites(manifest, "setup/*.yaml))
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Good point @pedjak, done! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We observe weird, behaviors with the GC when we delete the types (XRD, CRD or MRs) before children of those (MRs) are cleaned up properly.
This PR attempts to fix these by waiting until no composed resource is left before deleting the prerequisites, typically the manifest under setup dir.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, if necessary.Opened a PR updating the docs, if necessary.