Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix flakes with environment-configs suite #4847

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Oct 19, 2023

Description of your changes

Fixes the following flakes that we're observing with the recent PRs:

=== RUN   TestEnvironmentConfigMultipleMaxMatch1/TestEnvironmentConfigMultipleMaxMatch1/MRHasAnnotation
    feature.go:575: there were no unfiltered referred managed resources to check
--- FAIL: TestEnvironmentConfigMultipleMaxMatch1 (10.30s)
    --- FAIL: TestEnvironmentConfigMultipleMaxMatch1/TestEnvironmentConfigMultipleMaxMatch1 (10.30s)
        --- PASS: TestEnvironmentConfigMultipleMaxMatch1/TestEnvironmentConfigMultipleMaxMatch1/CreateClaim (0.51s)
        --- FAIL: TestEnvironmentConfigMultipleMaxMatch1/TestEnvironmentConfigMultipleMaxMatch1/MRHasAnnotation (0.51s)

See https://github.com/crossplane/crossplane/actions/runs/6570834969/job/17848891695?pr=4846

I have:

Need help with this checklist? See the cheat sheet.

@turkenh turkenh requested review from a team as code owners October 19, 2023 09:29
Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 637ba518d70e754fed81fa4f47a052fc3dff8b69)
@phisco phisco merged commit 742dfd8 into crossplane:master Oct 19, 2023
15 checks passed
@turkenh turkenh deleted the e2e-fix-env-flake branch October 19, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants