Don't auto-assign reviewers, for now #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Cope <nicc@rk0n.org>
turkenh
approved these changes
Oct 19, 2023
jbw976
reviewed
Oct 20, 2023
| # for final review. | ||
| # The goal of this file is for most PRs to automatically and fairly have 1 to 2 | ||
| # maintainers set as PR reviewers. All maintainers have permission to approve | ||
| # and merge PRs. PRs only need |
There was a problem hiding this comment.
looks like this sentence didn't get finished? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates CODEOWNERS to avoid auto-assigning reviewers, for now. Instead it assigns only maintainers.
We don't think this will be the end state, but we're taking a first step to simplify to avoid the following issues:
I have:
Runmake reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.