Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log for composition webhook schema validation as beta #4880

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix log for composition webhook schema validation as beta #4880

merged 1 commit into from
Oct 23, 2023
+10 −10

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Oct 23, 2023 •
edited

Description of your changes

Looks like we missed changing the log message in #4814.

I am getting the following logs on the latest master by default:

Defaulted container "crossplane" out of: crossplane, crossplane-init (init)
2023-10-23T05:47:12Z	INFO	crossplane	Beta feature enabled	{"flag": "EnableBetaCompositionFunctions"}
2023-10-23T05:47:12Z	INFO	crossplane	Alpha feature enabled	{"flag": "EnableAlphaCompositionWebhookSchemaValidation"}

I have:

Need help with this checklist? See the cheat sheet.

@turkenh
Fix log for CompositionWebhookSchemaValidation as beta
b3002cf 
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh requested review from negz, a team and phisco as code owners October 23, 2023 05:54
@turkenh turkenh requested a review from bobh66 October 23, 2023 05:54
phisco
phisco approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🙏

@turkenh turkenh merged commit 069e018 into crossplane:master Oct 23, 2023
18 checks passed
@turkenh turkenh deleted the schema-validation-as-beta branch October 23, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phisco phisco phisco approved these changes

@negz negz Awaiting requested review from negz negz is a code owner

@bobh66 bobh66 Awaiting requested review from bobh66 bobh66 is a code owner automatically assigned from crossplane/crossplane-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turkenh @phisco