Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a gRPC interceptor for function metrics #5006

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Add a gRPC interceptor for function metrics #5006

merged 5 commits into from
Nov 21, 2023

Commits on Nov 18, 2023

  1. Add a gRPC interceptor for function metrics 

    This adds some basic metrics for functions:

* RPCs started (count)
* RPCs handled (count)
* RPC compleition time (histogram)

While we probably want metrics like this, I don't think this premade
interceptor will work for us. It's close, but we probably want function
name/target as a label and this doesn't seem to give us that.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    aadd464 View commit details
    Browse the repository at this point in the history

  2. Use our own gRPC interceptor for composition function metrics 

    This allows us to add useful, function-specific metric labels including
what function is being called and the severity of the result.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ee56b19 View commit details
    Browse the repository at this point in the history

  3. Enable metrics during E2E tests 

    This is useful to be able to look at metrics after an E2E run.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    c02237e View commit details
    Browse the repository at this point in the history

  4. Make function metric labels more descriptive 

    Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    d7629e4 View commit details
    Browse the repository at this point in the history

  5. Use gRPC's status.FromError rather than our own 

    Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    4c9ebcc View commit details
    Browse the repository at this point in the history