feat(cli): sort composed resources in the render output #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phisco
force-pushed
the
dev/sort-render-output
branch
from
c9dce89
to
114f957
Compare
lsviben
approved these changes
Nov 17, 2023
|
@jbw976 I didn't add the backport label here as I don't see this as a "bug" in the current implementation, but I could be easily convinced otherwise, let me know what you think. |
negz
reviewed
Nov 18, 2023
phisco
force-pushed
the
dev/sort-render-output
branch
from
114f957
to
7c29be3
Compare
|
now I got why @haarchri, was talking about sorting by kind AND annotations... most of the times resources won't have a name as |
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
phisco
force-pushed
the
dev/sort-render-output
branch
from
7c29be3
to
7c033c5
Compare
negz
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #5008 by sorting composed resources by composed resource name (
crossplane.io/composition-resource-nameannotation) to ensure the output is stable.I have:
make reviewableto ensure this PR is ready for review.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.