Leave deletion of package service account to garbage collector #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
phisco
approved these changes
Nov 20, 2023
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When a package revision is inactive, it is unnecessary to keep its Service Account around; hence, we have been deleting it during deactivation. However, this causes unexpected behaviors when a Service Account name is specified via the deprecated
ControllerConfigor the newDeploymentRuntimeConfigsince the deleted Service Account is shared between revisions.How was it working before v1.14? We always had the delete call for SA during deactivation, however, we were not passing ControllerConfig to the function building the SA, hence SA with the name provided there was not deleted.
Fixes #5017
I have:
make reviewableto ensure this PR is ready for review.Added or updated e2e tests.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.