Use NameGenerator for composite name generation
#5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Nov 28, 2023
| // then we are going to update an existing composite, | ||
| // hijacking it from another claim. Depending on context/environment | ||
| // the consequences could be more or less serious. | ||
| // TODO: decide if we must prevent it. |
There was a problem hiding this comment.
to be clear here: this is the same in the old code, @pedjak just made it clearer here in the comment.
sttts
approved these changes
Nov 28, 2023
sttts
reviewed
Nov 28, 2023
sttts
reviewed
Nov 28, 2023
sttts
reviewed
Nov 28, 2023
|
|
||
| // GenerateName generates a name using the same algorithm as the API server, and | ||
| // verifies temporary name availability. It does not submit the composed | ||
| // resource to the API server and hence it does not fall over validation errors. |
There was a problem hiding this comment.
same, please adapt. This can be used for anything, no only composed resources.
sttts
reviewed
Nov 28, 2023
|
Some nits. |
The generator is already used for MR name generation. Changes: * since used by two controllers, `NameGenerator` moved under `internal/names` package * `configurator_test.go` updated Signed-off-by: Predrag Knezevic <predrag.knezevic@upbound.io>
pedjak
force-pushed
the
use-name-generator-for-composites
branch
from
4ba31ce
to
13c2d1f
Compare
turkenh
approved these changes
Nov 28, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The generator is already used for MR name generation.
Changes:
NameGeneratormoved underinternal/namespackageconfigurator_test.goupdatedRelated #4858
I have:
make reviewableto ensure this PR is ready for review.[ ] Added or updated e2e tests.[ ] Linked a PR or a docs tracking issue to document this change.[ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.