Add Skyscrapers to ADOPTERS.md #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iuri aranda <iuri.aranda@gmail.com>
iuriaranda
force-pushed
the
skyscrapers-adopter
branch
from
3aa4831
to
876a8ce
Compare
jbw976
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
LGTM, thank you @iuriaranda for sharing your adoption story with the community here! 🙇♂️
there are some merge conflicts to handle, but I will take a first stab at them now 😁
|
@iuriaranda looks like I don't have permissions this time to push the resolved merge conflicts to your fork/branch. Would you be able to take care of those so that we can get this great addition completed? Thank you! 🙇♂️ |
Signed-off-by: iuri aranda <iuri.aranda@gmail.com>
|
@jbw976 conflicts resolved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add Skyscrapers to ADOPTERS.md
I have:
Runmake reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.