Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crank): error out on timeout installing package #5207

Merged
merged 2 commits into from Jan 10, 2024

Conversation

phisco
Copy link
Contributor

@phisco phisco commented Jan 9, 2024

Description of your changes

Fixes #5149.

Built locally with make build, then:

# not existing provider
$ _output/bin/darwin_arm64/crank xpkg install provider crossplanecontrib/provider-nop:latest test --wait=1s && kubectl get providers

crossplane: error: Package did not become ready: context deadline exceeded

with exit code 1.

I have:

Need help with this checklist? See the cheat sheet.

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco phisco requested a review from a team as a code owner January 9, 2024 17:31
@phisco phisco requested a review from negz January 9, 2024 17:31
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @phisco! anything you can add to the PR about how you tested it and what the output looks like when this condition is hit? 🤔

cmd/crank/xpkg/install.go Outdated Show resolved Hide resolved
Co-authored-by: Jared Watts <jbw976@gmail.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco
Copy link
Contributor Author

phisco commented Jan 9, 2024

updated the description @jbw976. The Output is not the best, but we should address it more organically in my opinion.

@jbw976
Copy link
Member

jbw976 commented Jan 9, 2024

cool! looks reasonable enough for me now 👍

@negz
Copy link
Member

negz commented Jan 9, 2024

@phisco Do you want to back port this? Just asking because you left the relevant box unticked.

@phisco
Copy link
Contributor Author

phisco commented Jan 10, 2024

@negz I was thinking about that, yes. I'm not sure it's actually worth it with a release due soon, I could be easily convinced it's not, WDYT?

@phisco phisco merged commit d67f1ea into crossplane:master Jan 10, 2024
17 of 19 checks passed
Copy link

Successfully created backport PR for release-1.14:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--wait flag on package install doesn't do anything when the wait timeout expires before the package is healthy
3 participants