Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump k8s io dependencies to v0.29.1 #5315

Merged
merged 1 commit into from Feb 1, 2024

Conversation

MisterMX
Copy link
Contributor

@MisterMX MisterMX commented Jan 31, 2024

Description of your changes

This bumps k8s.io/client.go and all other k8s dependencies to v0.29.1. It applies a manual fix due to a breaking change in k8s.io/client-go/restmapper (boo to the devs for this unnecessary breaking change ;-) )

Regarding the change: It is safe to pass nil because of kubernetes/client-go@57d597c.

I have:

Need help with this checklist? See the cheat sheet.

@MisterMX MisterMX requested review from phisco and a team as code owners January 31, 2024 13:46
@MisterMX MisterMX requested a review from turkenh January 31, 2024 13:46
@MisterMX MisterMX changed the title chore: Bump k8s/client-go to v0.29.1 chore: Bump k8s io dependencies to v0.29.1 Jan 31, 2024
Copy link
Contributor

@bobh66 bobh66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to let these changes come from crossplane-runtime. The renovate configuration in this repo has comments to that effect.

@phisco
Copy link
Contributor

phisco commented Jan 31, 2024

yes, we should merge this first

Make a small adjustment to apply to a breaking change in
`k8s.io/client-go/restmapper`.

Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
@phisco
Copy link
Contributor

phisco commented Feb 1, 2024

@MisterMX can you update this PR to pull in the latest crossplane-runtime 1.15 (go get -u github.com/crossplane/crossplane-runtime@release-1.15; go mod tidy)?

@MisterMX MisterMX force-pushed the chore/k8s-client-go-v0.29.1 branch 2 times, most recently from 021a9d9 to ade5824 Compare February 1, 2024 16:58
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @MisterMX

@phisco phisco merged commit b40b964 into crossplane:master Feb 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants