-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added debug logs for render command #5328
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -20,6 +20,7 @@ import ( | |||||
"context" | ||||||
|
||||||
"github.com/crossplane/crossplane-runtime/pkg/errors" | ||||||
"github.com/crossplane/crossplane-runtime/pkg/logging" | ||||||
|
||||||
pkgv1beta1 "github.com/crossplane/crossplane/apis/pkg/v1beta1" | ||||||
) | ||||||
|
@@ -49,7 +50,7 @@ const ( | |||||
// A Runtime runs a Function. | ||||||
type Runtime interface { | ||||||
// Start the Function. | ||||||
Start(ctx context.Context) (RuntimeContext, error) | ||||||
Start(ctx context.Context, logger logging.Logger) (RuntimeContext, error) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Nit. Or |
||||||
} | ||||||
|
||||||
// RuntimeContext contains context on how a Function is being run. | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to pass the logger in
GetRuntime
? So it would be a field of the runtime struct rather than an argument to theStart
method?