fix(crank/render): conditions' lastTransitionTime can not be null #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
bobh66
approved these changes
Feb 6, 2024
|
Successfully created backport PR for |
negz
reviewed
Feb 6, 2024
| xrCond.LastTransitionTime = metav1.Time{} | ||
| // lastTransitionTime would just be noise, but we can't drop it as it's a | ||
| // required field and null is not allowed, so we set a random time. | ||
| xrCond.LastTransitionTime = metav1.NewTime(time.Date(2024, time.January, 1, 0, 0, 0, 0, time.UTC)) |
There was a problem hiding this comment.
Just to make it stable, I imagined someone comparing the output to some static file and the random timestamp would have made it needlessly harder to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow up for #5305, testing out https://github.com/phisco/function-environment-configs I noticed that lastTransitionTime can not be set to null 🤦♂️:
With this we set it to a random fixed date, so that it's still consistent for downstream consumers:
/Users/phisco/github.com/crossplane/crossplane/_output/bin/darwin_arm64/crank beta render \ --extra-resources example/environmentConfigs.yaml \ --include-full-xr \ example/xr.yaml example/composition.yaml example/functions.yaml | /Users/phisco/github.com/crossplane/crossplane/_output/bin/darwin_arm64/crank beta validate example - [✓] example.crossplane.io/v1, Kind=XR, example-xr validated successfully Total 1 resources: 0 missing schemas, 1 success cases, 0 failure casesI have:
make reviewableto ensure this PR is ready for review.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.