Update ignore-changes docs managementPolicy => managementPolicies
#5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
reviewed
Feb 13, 2024
design/one-pager-ignore-changes.md
Outdated
|
|
||
| ```yaml | ||
| # Default | ||
| spec: | ||
| managementPolicy: FullControl | ||
| ManagementPolicies: FullControl |
There was a problem hiding this comment.
Suggested change
| ManagementPolicies: FullControl | |
| managementPolicies: FullControl |
I think all of these should be managementPolicies with a lower case m.
There was a problem hiding this comment.
Ahh right 🤦 updated with lowercase.
Signed-off-by: Fatih Türken <turkenf@gmail.com>
turkenf
force-pushed
the
update-ignore-ch
branch
from
40ca24c
to
e401acc
Compare
turkenf
changed the title
managementPolicy => ManagementPoliciesmanagementPolicy => managementPolicies
negz
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates
managementPoliciesdocumentation indesign/one-pager-ignore-changes.mdfile.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.